As an aside, we need to figure out a way for providers to register their logger with the core app. /cc @durandom

Checked commit blomquisg@a64af1c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 1 offense detected

lib/vmdb/loggers.rb

• ❗ - Line 37, Col 34 - Style/GlobalVars - Do not introduce global variables.

❗️ - Line 37, Col 34 - Style/GlobalVars - Do not introduce global variables.

I thought we did logging in a different way than with the $ now to appease the Rubocops?

LGTM 👍

@blomquisg I had ideas about not creating separate $loggers at all. Basically, each plugin could be "given" a dedicated logger object by the server. Then the code within the plugin would call ManageIQ::Providers::Whoever.logger Then the provider is responsible for using that method, and the server is responsible for populating it on boot. Options for the logger would be within the Settings namespace for that provider. (more or less 😉 )

^^ This would of course depend on the Settings pluggability...I have to find time to review @durandom's stuff :)

@Fryguy Sounds like a great idea.

@juliancheal said:

I thought we did logging in a different way than with the $ now to appease the Rubocops?

None that I know of ...

@Fryguy said:

I had ideas about not creating separate $loggers ...

heh, I was gonna respond about Settings ... but you beat me